Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates bower and fix null pointer #3

Closed
wants to merge 3 commits into from
Closed

Updates bower and fix null pointer #3

wants to merge 3 commits into from

Conversation

mtraynham
Copy link
Contributor

Updates the bower main to use non-minified file.
Update to jstree 3.0.6.
Removed the reference to controller.nodes (seems unnecessary, if you just pass it from the directive).
Fixed a null pointer where the $scope.treeData may not be initialized yet.

…ix for null pointer of .treeData and removed controller.nodes (not necessary).
@ezraroi
Copy link
Owner

ezraroi commented Oct 16, 2014

Hi, the build failed as a test failed. Can you check it?

@ezraroi ezraroi closed this Oct 16, 2014
@mtraynham
Copy link
Contributor Author

Looks like you already modified the bower files, so those can probably be overlooked. Seems to run npm test fine locally. Let me check your tests.

Also, I think you closed this by accident :P

@mtraynham
Copy link
Contributor Author

Hmm, seems to be unrelated to my changes. If I revert everything, I still get the issue. Will let you know.

@ezraroi
Copy link
Owner

ezraroi commented Oct 16, 2014

I think it was closed automatically because the build failed. Run grunt karma or grunt test

@ezraroi ezraroi reopened this Oct 16, 2014
@ezraroi
Copy link
Owner

ezraroi commented Oct 16, 2014

The build is still failing... i fixed the code in my branch already. Thanks anyway, I hope that next pull request will pass :)

@ezraroi ezraroi closed this Oct 16, 2014
@mtraynham
Copy link
Contributor Author

Well there was a null pointer fix in my changeset that didn't get picked up, but I'm just going to delete the branch and try a different pull request. When I checkout my branch locally, the tests seem to run fine. The way travis checks out the pull request is when it fails. The message karma returns is not entirely helpful either... and after Googling a bit, it may be related to missing tests.

Running "karma:unit" (karma) task
INFO [karma]: Karma v0.12.24 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.7 (Linux)]: Connected on socket g97gf0_JiU4lZUiYTWDp with id 25873244
Warning: Task "karma:unit" failed. Use --force to continue.

@mtraynham mtraynham deleted the fix_bower_and_scope branch October 16, 2014 14:31
@ezraroi
Copy link
Owner

ezraroi commented Oct 16, 2014

You can use the karma cli (karma start), this should give you a better info why it is failing. Also you can change the karma log level to debug in the karma.conf file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants