-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates bower and fix null pointer #3
Conversation
…ix for null pointer of .treeData and removed controller.nodes (not necessary).
Hi, the build failed as a test failed. Can you check it? |
Looks like you already modified the bower files, so those can probably be overlooked. Seems to run Also, I think you closed this by accident :P |
Hmm, seems to be unrelated to my changes. If I revert everything, I still get the issue. Will let you know. |
I think it was closed automatically because the build failed. Run grunt karma or grunt test |
The build is still failing... i fixed the code in my branch already. Thanks anyway, I hope that next pull request will pass :) |
Well there was a null pointer fix in my changeset that didn't get picked up, but I'm just going to delete the branch and try a different pull request. When I checkout my branch locally, the tests seem to run fine. The way travis checks out the pull request is when it fails. The message karma returns is not entirely helpful either... and after Googling a bit, it may be related to missing tests.
|
You can use the karma cli (karma start), this should give you a better info why it is failing. Also you can change the karma log level to debug in the karma.conf file |
Updates the bower main to use non-minified file.
Update to jstree 3.0.6.
Removed the reference to controller.nodes (seems unnecessary, if you just pass it from the directive).
Fixed a null pointer where the $scope.treeData may not be initialized yet.