fby4: sd: pldm sensors: remove threshold of FIO temperature #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
|
Looks like the clang-format has error, please fix it and put up a new patch. |
Description:
Remove threshold of FIO temperature sensors.
Motivation:
Remove threshold of MB_FIO_TEMP_C since the sensor will be
calibrated in virtual sensor service in BMC.
Test plan:
Check that there is no threshold interface in MB_FIO_TEMP_C.
Test logs:
- Check that there is no threshold interface in MB_FIO_TEMP_C.
root@bmc:~# busctl introspect xyz.openbmc_project.PLDM /xyz/openbmc_project/sensors/temperature/SENTINEL_DOME_SLOT_1_MB_FIO_TEMP_C
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openbmc… emits-change writable
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 0 emits-change writable
.MinValue property d 0 emits-change writable
.Unit property s "xyz.openbmc_project.Sensor.Value.Unit.… emits-change writable
.Value property d 27 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change writable
RickyWu-wiwynn
force-pushed
the
Ricky/yv4_sd/remove_fio_thres
branch
from
7131fd7 to
d1c82ee
Compare
|
@SaraLin-wiwynn has updated the pull request. You must reimport the pull request before landing. |
|
Hi @wangx6f, |
|
This pull request has been merged in fc63b01. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove threshold of FIO temperature sensors.
Motivation:
Remove threshold of MB_FIO_TEMP_C since the sensor will be calibrated in virtual sensor service in BMC.
Test plan:
Check that there is no threshold interface in MB_FIO_TEMP_C.
Test logs:
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Association.Definitions interface - - -
.Associations property a(sss) 1 "chassis" "all_sensors" "/xyz/openbmc… emits-change writable
xyz.openbmc_project.Sensor.Value interface - - -
.MaxValue property d 0 emits-change writable
.MinValue property d 0 emits-change writable
.Unit property s "xyz.openbmc_project.Sensor.Value.Unit.… emits-change writable
.Value property d 27 emits-change writable
xyz.openbmc_project.State.Decorator.Availability interface - - -
.Available property b true emits-change writable
xyz.openbmc_project.State.Decorator.OperationalStatus interface - - -
.Functional property b true emits-change writable