Skip to content

Commit

Permalink
Add some constraints to allowlist
Browse files Browse the repository at this point in the history
Summary:
Based on existing samples of soft errors, add existing constraints to the CI allowlist for CLI modifiers.
The allowlist is roughly divided into two sections. One for legal use cases and one for temporary migration use cases.
Roughly divided these based on observing the use cases and chatting with engineers that introduced the use of `--modifier` flags.

Reviewed By: Will-MingLun-Li

Differential Revision: D62679299

fbshipit-source-id: c4306f5fdcd58543f6a920f51862e467bf5e1e08
  • Loading branch information
Scott Cao authored and facebook-github-bot committed Sep 18, 2024
1 parent 759e793 commit d90dcbc
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ async def test_cfg_constructor_with_target_modifiers(buck: Buck) -> None:
)
async def test_invoke_cfg_constructors_with_cli_modifier_validation(buck: Buck) -> None:
env = {
"BUCK2_HARD_ERROR": "only=starlark_cli_modifier_fails_ci_allowlist_version_two"
"BUCK2_HARD_ERROR": "only=starlark_cli_modifier_fails_ci_allowlist_version_three"
}
await buck.cquery(
"fbcode//buck2/tests/e2e/configurations/cfg_constructor/test_clear_package_modifiers_data/test_cfg_constructor_data:has_target_modifier",
Expand Down

0 comments on commit d90dcbc

Please sign in to comment.