Skip to content

Commit

Permalink
fix(spaces): rename dyno cidrs to space cidrs (heroku#958)
Browse files Browse the repository at this point in the history
Jillian Tullo authored and jdx committed Jul 25, 2018
1 parent b2f6b03 commit 437ad62
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/spaces/commands/peering/info.js
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ module.exports = {
AWS Region: us-west-2
AWS VPC ID: vpc-baadf00d
AWS VPC CIDR: 10.0.0.0/16
Dyno CIDRs: 10.0.128.0/20, 10.0.144.0/20
Space CIDRs: 10.0.128.0/20, 10.0.144.0/20
Unavailable CIDRs: 10.1.0.0/16
You will use the information provied by this command to establish a peering connection request from your AWS VPC to your private space.
4 changes: 2 additions & 2 deletions packages/spaces/lib/peering.js
Original file line number Diff line number Diff line change
@@ -27,9 +27,9 @@ module.exports = function (heroku) {
'AWS Region': info.aws_region,
'AWS VPC ID': info.vpc_id,
'AWS VPC CIDR': info.vpc_cidr,
'Dyno CIDRs': format.CIDR(info.dyno_cidr_blocks),
'Space CIDRs': format.CIDR(info.space_cidr_blocks),
'Unavailable CIDRs': format.CIDR(info.unavailable_cidr_blocks)
}, ['AWS Account ID', 'AWS Region', 'AWS VPC ID', 'AWS VPC CIDR', 'Dyno CIDRs', 'Unavailable CIDRs'])
}, ['AWS Account ID', 'AWS Region', 'AWS VPC ID', 'AWS VPC CIDR', 'Space CIDRs', 'Unavailable CIDRs'])
}

function displayPeers (space, peers) {
4 changes: 2 additions & 2 deletions packages/spaces/test/commands/peering/info.js
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ let info = {
aws_region: 'us-west-2',
vpc_id: 'vpc-1234568a',
vpc_cidr: '10.0.0.0/16',
dyno_cidr_blocks: ['10.0.128.0/20', '10.0.144.0/20'],
space_cidr_blocks: ['10.0.128.0/20', '10.0.144.0/20'],
unavailable_cidr_blocks: ['192.168.2.0/30']}

describe('spaces:peering-info', function () {
@@ -29,7 +29,7 @@ AWS Account ID: 012345678900
AWS Region: us-west-2
AWS VPC ID: vpc-1234568a
AWS VPC CIDR: 10.0.0.0/16
Dyno CIDRs: 10.0.128.0/20, 10.0.144.0/20
Space CIDRs: 10.0.128.0/20, 10.0.144.0/20
Unavailable CIDRs: 192.168.2.0/30
`))
.then(() => api.done())

0 comments on commit 437ad62

Please sign in to comment.