BP: AbstractRendererXY: Update axesList of AbstractRenderer when changed (#677) #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedeibel
force-pushed
the
bug/677-data-point-tooltip-not-working
branch
from
2c99006 to
01ae0a9
Compare
|
RalphSteinhagen
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
@dedeibel thanks for your PR! This looks OK. Thanks for also providing a unit-test.
As a minor request: if you could add a null pointer check for the rare case that there isn't any original axis before the updateAxes() call. We do not want to nullify any valid new axis. 😄
Since this is minor, it could be squash-merged afterwards w/o further review.
chartfx-chart/src/main/java/io/fair_acc/chartfx/renderer/spi/AbstractRendererXY.java
Show resolved
Hide resolved
|
Thank you for your review! I will keep your suggestion in mind and hope we can get back to it if any problems with null values arise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #677