Fixes side effects with application_controller_patch #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I observed some strange side effects with your latest changes by adding the application_controller_patch.rb.
The problem occurs due to requiring ApplicationController:
It only happens under certain circumstances (see xmera Circle issue 1444).
Since the code runs even without the requirement above I deleted the line in redmine_message_customize/lib/message_customize/application_controller_patch.rb.
It would be great when you could merge this change.
Thank you! :)
Best Regards,
@liaham