Use "immutable" Cache-Control extension

See http://bitsup.blogspot.com/2016/05/cache-control-immutable.html for more info. Fixes unpkg#103 Closes unpkg#119
fastly · Sep 1, 2018 · 2fc84df · 2fc84df
1 parent fe48506
commit 2fc84df
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/modules/actions/serveJavaScriptModule.js b/modules/actions/serveJavaScriptModule.js
@@ -40,7 +40,7 @@ function serveJavaScriptModule(req, res) {
       .set({
         "Content-Length": Buffer.byteLength(code),
         "Content-Type": getContentTypeHeader(req.entry.contentType),
-        "Cache-Control": "public,max-age=31536000", // 1 year
+        "Cache-Control": "public, max-age=31536000, immutable", // 1 year
         ETag: etag(code),
         "Cache-Tag": "file,js-file,js-module"
       })

diff --git a/modules/actions/serveMetadata.js b/modules/actions/serveMetadata.js
@@ -35,7 +35,7 @@ function serveMetadata(req, res) {
 
   res
     .set({
-      "Cache-Control": "public,max-age=31536000", // 1 year
+      "Cache-Control": "public, max-age=31536000, immutable", // 1 year
       "Cache-Tag": "meta"
     })
     .send(metadata);

diff --git a/modules/actions/serveStaticFile.js b/modules/actions/serveStaticFile.js
@@ -15,7 +15,7 @@ function serveStaticFile(req, res) {
     .set({
       "Content-Length": req.entry.size,
       "Content-Type": getContentTypeHeader(req.entry.contentType),
-      "Cache-Control": "public,max-age=31536000", // 1 year
+      "Cache-Control": "public, max-age=31536000, immutable", // 1 year
       "Last-Modified": req.entry.lastModified,
       ETag: etag(req.entry.content),
       "Cache-Tag": tags.join(",")

diff --git a/modules/middleware/fetchPackage.js b/modules/middleware/fetchPackage.js
@@ -92,8 +92,8 @@ function filenameRedirect(req, res) {
   // and URLs resolve correctly.
   res
     .set({
-      "Cache-Control": "public,max-age=31536000", // 1 year
-      "Cache-Tag": "redirect,filename-redirect"
+      "Cache-Control": "public, max-age=31536000, immutable", // 1 year
+      "Cache-Tag": "redirect, filename-redirect"
     })
     .redirect(
       302,

diff --git a/modules/middleware/findFile.js b/modules/middleware/findFile.js
@@ -12,8 +12,8 @@ function indexRedirect(req, res, entry) {
   // resolve correctly.
   res
     .set({
-      "Cache-Control": "public,max-age=31536000", // 1 year
-      "Cache-Tag": "redirect,index-redirect"
+      "Cache-Control": "public, max-age=31536000, immutable", // 1 year
+      "Cache-Tag": "redirect, index-redirect"
     })
     .redirect(
       302,