Merge pull request phpbb#4990 from rubencm/ticket/15377

[ticket/15377] Fix INCLUDECSS and INCLUDEJS
fe-brauer · Oct 9, 2017 · 68b3da2 · 68b3da2
2 parents eb0122b + eaeec9b
commit 68b3da2
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/phpBB/phpbb/template/twig/loader.php b/phpBB/phpbb/template/twig/loader.php
@@ -22,6 +22,16 @@ class loader extends \Twig_Loader_Filesystem
 {
 	protected $safe_directories = array();
 
+	/**
+	 * Constructor
+	 *
+	 * @param string|array	$paths
+	 */
+	public function __construct($paths = array())
+	{
+		parent::__construct($paths, __DIR__);
+	}
+
 	/**
 	* Set safe directories
 	*

diff --git a/tests/functional/extension_controller_test.php b/tests/functional/extension_controller_test.php
@@ -89,6 +89,15 @@ public function test_controller_with_template()
 		$this->phpbb_extension_manager->purge('foo/bar');
 	}
 
+	/**
+	* Check includejs/includecss when the request_uri is a subdirectory
+	*/
+	public function test_controller_template_include_js_css()
+	{
+		$crawler = self::request('GET', 'app.php/help/faq');
+		$this->assertContains("./../../assets/javascript/core.js", $crawler->filter('body')->html());
+	}
+
 	/**
 	* Check the error produced by calling a controller without a required
 	* argument.