download specs for koji scratch builds #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from their SRPMs - this reintroduces the codebase originally written by @nikromen, hence the co-authorship If fetching of a spec file fails, return None instead of erroring out. We want to have the annotated snippets and can live if a few don't have spec files. Fixes fedora-copr#98 Co-authored-by: Jiri Kyjovsky <[email protected]> Signed-off-by: Tomas Tomecek <[email protected]>
nikromen
approved these changes
Jan 30, 2024
| ), | ||
| status_code=HTTPStatus.BAD_REQUEST, | ||
| ) | ||
| # since we require arch in the input, we can check if the task matches it |
There was a problem hiding this comment.
I think the initial idea of arch here was when the user gives us arch and task ID with children, we could go to the specific child. But it somehow disappeared into the thin air. And also I am not sure if it would work :D
There was a problem hiding this comment.
you're right, we do that when the ID is build-id
but once they provide task id, we now require it to be the buildArch (or SCM) task so we can get the logs and spec right away
There was a problem hiding this comment.
though we don't accept the parent task right now :/ #97
| ) | ||
| # since we require arch in the input, we can check if the task matches it | ||
| # but I think it's not a good UX, if the user gives us task ID, let's just use it | ||
| # if someone complains about, just reintroduce the if below |
|
@nikromen thank you for the review!! merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from their SRPMs - this reintroduces the codebase
originally written by @nikromen, hence the co-authorship
If fetching of a spec file fails, return None instead of erroring out.
We want to have the annotated snippets and can live if a few don't have
spec files.
Fixes #98