wip

felipepodesta · Aug 28, 2019 · cc5f9cb · cc5f9cb
2 parents f2812e9 + 3c937a7
commit cc5f9cb
Show file tree

Hide file tree

Showing 11 changed files with 28 additions and 13 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,5 @@
 /build
 /coverage
-/docs
 /node_modules
 /resources/compiled/index.html
 /vendor

diff --git a/README.md b/README.md
@@ -8,6 +8,8 @@
 Ignition offers you a beautiful, customizable error screen. It also allows you to share your errors to Flare publicly. 
 If configured with a valid Flare API key, it will send errors to a project in your Flare account.
 
+![Screenshot of ignition](https://facade.github.io/ignition/screenshot.png)
+
 ## Official Documentation
 
 The official documentation for Ignition can be found on the [Flare website](http://flareapp.io.test/docs/ignition-for-facade/installation).

diff --git a/docs/screenshot.png b/docs/screenshot.png
diff --git a/resources/compiled/ignition.js b/resources/compiled/ignition.js
diff --git a/resources/js/components/Shared/ErrorCard.vue b/resources/js/components/Shared/ErrorCard.vue
@@ -29,7 +29,7 @@
                         </a>
                         <FilePath
                             pathClass="font-normal text-gray-600"
-                            :file="report.application_path + '/'"
+                            :file="report.application_path + config.directorySeparator"
                             :relative="false"
                         />
                     </div>
@@ -57,7 +57,7 @@ import OccurrenceDetails from './OccurrenceDetails';
 import FilePath from './FilePath.vue';
 
 export default {
-    inject: ['report', 'telescopeUrl'],
+    inject: ['report', 'telescopeUrl', 'config'],
 
     components: {
         OccurrenceDetails,

diff --git a/resources/js/components/Shared/editorUrl.js b/resources/js/components/Shared/editorUrl.js
@@ -11,6 +11,10 @@ export default function editorUrl(editor, file, lineNumber) {
     };
 
     if (!Object.keys(editors).includes(editor)) {
+        console.error(
+            `'${editor}' is not supported. Support editors are: ${Object.keys(editors).join(', ')}`,
+        );
+
         return null;
     }
 

diff --git a/resources/views/errorPage.php b/resources/views/errorPage.php
@@ -1,11 +1,11 @@
 <!doctype html>
 <html>
 <head>
-    <!-- Hide dumps asap -->		
-    <style>		
-        pre.sf-dump {		
-            display: none !important;		
-        }		
+    <!-- Hide dumps asap -->
+    <style>
+        pre.sf-dump {
+            display: none !important;
+        }
     </style>
 
     <meta charset="UTF-8">

diff --git a/src/Commands/TestCommand.php b/src/Commands/TestCommand.php
@@ -77,7 +77,7 @@ protected function sendTestException()
             app('flare.client')->sendTestReport($testException);
             $this->info(PHP_EOL);
         } catch (Exception $exception) {
-            $this->warn('❌ We were unable to send an exception to Flare. Make sure that your key is correct and that you have a valid subscription.  For more info visit the docs on installing Flare in a Laravel project: http://flareapp.io/docs/flare-for-laravel/installation');
+            $this->warn('❌ We were unable to send an exception to Flare. Make sure that your key is correct and that you have a valid subscription. ' . PHP_EOL . PHP_EOL . 'For more info visit the docs on installing Flare in a Laravel project: http://flareapp.io/docs/flare-for-laravel/installation');
 
             return;
         }

diff --git a/src/Facades/Flare.php b/src/Facades/Flare.php
@@ -4,6 +4,15 @@
 
 use Illuminate\Support\Facades\Facade;
 
+/**
+ * Class Flare
+ *
+ * @method static void glow(string $name, string $messageLevel = \Facade\FlareClient\Enums\MessageLevels::INFO, array $metaData = [])
+ * @method static void context($key, $value)
+ * @method static void group(string $groupName, array $properties)
+ *
+ * @see \Facade\FlareClient\Flare
+ */
 class Flare extends Facade
 {
     protected static function getFacadeAccessor()

diff --git a/src/IgnitionConfig.php b/src/IgnitionConfig.php
@@ -30,6 +30,7 @@ public function toArray(): array
         return [
             'editor' => $this->getEditor(),
             'theme' => $this->getTheme(),
+            'directorySeparator' => DIRECTORY_SEPARATOR,
         ];
     }
 

diff --git a/src/IgnitionServiceProvider.php b/src/IgnitionServiceProvider.php
@@ -336,13 +336,13 @@ protected function bindLogListener()
 
     protected function getConfigFileLocation(): ?string
     {
-        $configFullPath = base_path()."/.ignition";
+        $configFullPath = base_path().DIRECTORY_SEPARATOR.'.ignition';
 
         if (file_exists($configFullPath)) {
             return $configFullPath;
         }
 
-        $configFullPath = Arr::get($_SERVER, 'HOME', '') ."/.ignition";
+        $configFullPath = Arr::get($_SERVER, 'HOME', '').DIRECTORY_SEPARATOR.'.ignition';
 
         if (file_exists($configFullPath)) {
             return $configFullPath;