Skip to content

Commit

Permalink
Remove appveyor.yml (zarr-developers#706)
Browse files Browse the repository at this point in the history
* Remove appveyor.yml

The only additional test provided by appveyor is running
Python 3.6 and 3.7 with ZARR_ABS=0. These can be run via
GitHub Actions.

* Remove references to appveyor and coveralls
  • Loading branch information
joshmoore authored Mar 3, 2021
1 parent e4d5479 commit a4fc2c1
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 65 deletions.
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ TODO:
* [ ] Add docstrings and API docs for any new/modified user-facing classes and functions
* [ ] New/modified features documented in docs/tutorial.rst
* [ ] Changes documented in docs/release.rst
* [ ] AppVeyor and Travis CI passes
* [ ] Test coverage is 100% (Coveralls passes)
* [ ] GitHub Actions have all passed
* [ ] Test coverage is 100% (Codecov passes)
51 changes: 0 additions & 51 deletions appveyor.yml

This file was deleted.

20 changes: 9 additions & 11 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,11 @@ server locally and set the environment variable ``ZARR_TEST_MONGO=1``.
To run the Redis storage tests, run a Redis server locally on port
6379 and set the environment variable ``ZARR_TEST_REDIS=1``.

All tests are automatically run via Travis (Linux) and AppVeyor
(Windows) continuous integration services for every pull
request. Tests must pass under both Travis and Appveyor before code
can be accepted. Test coverage is also collected automatically via the
Coveralls service, and total coverage over all builds must be 100%
(although individual builds may be lower due to Python 2/3 or other
differences).
All tests are automatically run via GitHub Actions for every pull
request and must pass before code can be accepted. Test coverage is
also collected automatically via the Codecov service, and total
coverage over all builds must be 100% (although individual builds
may be lower due to Python 2/3 or other differences).

Code standards
~~~~~~~~~~~~~~
Expand All @@ -196,8 +194,8 @@ and produce a coverage report. This should be 100% before code can be accepted i
main code base.

When submitting a pull request, coverage will also be collected across all supported
Python versions via the Coveralls service, and will be reported back within the pull
request. Coveralls coverage must also be 100% before code can be accepted.
Python versions via the Codecov service, and will be reported back within the pull
request. Codecov coverage must also be 100% before code can be accepted.

Documentation
~~~~~~~~~~~~~
Expand Down Expand Up @@ -239,8 +237,8 @@ Pull requests submitted by an external contributor should be reviewed and approv
one core developers before being merged. Ideally, pull requests submitted by a core developer
should be reviewed and approved by at least one other core developers before being merged.

Pull requests should not be merged until all CI checks have passed (Travis, AppVeyor,
Coveralls) against code that has had the latest master merged in.
Pull requests should not be merged until all CI checks have passed (GitHub Actions
Codecov) against code that has had the latest master merged in.

Compatibility and versioning policies
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion requirements_dev_optional.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ lmdb==0.97; sys_platform != 'win32'
ipytree==0.1.3
# optional library requirements for services
# don't let pyup change pinning for azure-storage-blob, need to pin to older
# version to get compatibility with azure storage emulator on appveyor
# version to get compatibility with azure storage emulator on appveyor (FIXME)
azure-storage-blob==2.0.1 # pyup: ignore
redis==3.3.8
pymongo==3.9.0
Expand Down

0 comments on commit a4fc2c1

Please sign in to comment.