Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify panic message for too-big shift operations on BitSlices #176

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

rbeard0330
Copy link
Contributor

Thanks for creating this library. I was using this crate in a project of mine, and I got a confusing error message when I tried to shift a BitSlice by an amount equal to its length: cannot shift a bit-slice by more than its length: 100 > 100. This PR just rewords the error message to read: shift must be less than the length of the bit-slice: 100 >= 100.

I also double-checked the docs, and they correctly describe the requirement for the shift operation.

Hope this helps!

@myrrlyn
Copy link
Collaborator

myrrlyn commented Jul 1, 2022

Thank you so much!

@myrrlyn myrrlyn merged commit ad5dd00 into ferrilab:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants