Skip to content

Commit

Permalink
Add geomean column earlier to dataout as Series in compare.py.
Browse files Browse the repository at this point in the history
This fixes the following error when using --all.

Traceback (most recent call last):

    File "test-suite/utils/compare.py", line 374, in <module>
      print_result(data, limit_output, shorten_names, config.show_diff, sortkey)
    File "test-suite/utils/compare.py", line 227, in print_result
      dataout = add_geomean_row(d, dataout)
    File "test-suite/utils/compare.py", line 139, in add_geomean_row
      relative = values1 / values0
    File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1583, in wrapper
      result = safe_na_op(lvalues, rvalues)
    File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1533, in safe_na_op
      lambda x: op(x, rvalues))
    File "pandas/_libs/algos.pyx", line 690, in pandas._libs.algos.arrmap
    File "pyvenv/lib/python2.7/site-packages/pandas/core/ops.py", line 1533, in <lambda>
      lambda x: op(x, rvalues))
    TypeError: ufunc 'true_divide' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

Reviewed By: paquette

Differential Revision: https://reviews.llvm.org/D64066

llvm-svn: 367002
  • Loading branch information
fhahn committed Jul 25, 2019
1 parent 900dc52 commit c726835
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions utils/compare.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ def add_geomean_row(data, dataout):

gm_row = {c: '' for c in dataout.columns}
gm_row['diff'] = gm_diff
gm_row['Program'] = 'Geomean difference'
return dataout.append(gm_row, ignore_index=True)
series = pd.Series(gm_row, name='Geomean difference')
return dataout.append(series)

def filter_failed(data, key='Exec'):
return data.loc[data[key] == "pass"]
Expand Down Expand Up @@ -220,12 +220,12 @@ def print_result(d, limit_output=True, shorten_names=True,
# Take 15 topmost elements
dataout = dataout.head(15)

if show_diff_column:
dataout = add_geomean_row(d, dataout)

# Turn index into a column so we can format it...
dataout.insert(0, 'Program', dataout.index)

if show_diff_column:
dataout = add_geomean_row(d, dataout)

formatters = dict()
formatters['diff'] = format_diff
if shorten_names:
Expand Down

0 comments on commit c726835

Please sign in to comment.