Ensure correct parameter types in queries

fiedsch · Sep 25, 2023 · b5e11d1 · b5e11d1
1 parent 43a18a6
commit b5e11d1
Showing 1 changed file with 19 additions and 3 deletions.
diff --git a/src/Internal/Engine.php b/src/Internal/Engine.php
@@ -5,6 +5,7 @@
 namespace Loupe\Loupe\Internal;
 
 use Doctrine\DBAL\Connection;
+use Doctrine\DBAL\ParameterType;
 use Loupe\Loupe\Configuration;
 use Loupe\Loupe\IndexResult;
 use Loupe\Loupe\Internal\Filter\Parser;
@@ -193,10 +194,10 @@ public function upsert(
             $query .= ' WHERE ' . implode(' AND ', $where);
         }
 
-        $existing = $this->getConnection()->executeQuery($query, $parameters)->fetchAssociative();
+        $existing = $this->getConnection()->executeQuery($query, $parameters, $this->extractDbalTypes($parameters))->fetchAssociative();
 
         if ($existing === false) {
-            $this->getConnection()->insert($table, $insertData);
+            $this->getConnection()->insert($table, $insertData, $this->extractDbalTypes($insertData));
 
             return (int) $this->getConnection()->lastInsertId();
         }
@@ -224,8 +225,23 @@ public function upsert(
             $query .= ' WHERE ' . implode(' AND ', $where);
         }
 
-        $this->getConnection()->executeStatement($query, $parameters);
+        $this->getConnection()->executeStatement($query, $parameters, $this->extractDbalTypes($parameters));
 
         return $insertIdColumn !== '' ? (int) $existing[$insertIdColumn] : null;
     }
+
+    private function extractDbalTypes(array $data): array
+    {
+        $types = [];
+
+        foreach ($data as $k => $v) {
+            $types[$k] = match (\gettype($v)) {
+                'boolean' => ParameterType::BOOLEAN,
+                'integer' => ParameterType::INTEGER,
+                default => ParameterType::STRING
+            };
+        }
+
+        return $types;
+    }
 }