Skip to content

Code Quality: Fixed pointer states on Omnibar clear button #17230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jun 30, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Focused Omnibar textbox
  2. Confirmed the clear button has the correct pointer states

@yaira2 yaira2 requested a review from 0x5bfa July 1, 2025 01:20
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks more obvious. LGTM.

Before:
image
After:
image

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 1, 2025
@yaira2 yaira2 merged commit d7fd218 into main Jul 1, 2025
9 checks passed
@yaira2 yaira2 deleted the ya/DeleteButton branch July 1, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants