Skip to content

Code Quality: Prevent mode button from removing Omnibar focus #17242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jul 3, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Confirmed that focusing on Omnibar Mode button doesn't remove focus from Omnibar
  2. Confirmed that clicking UI elements outside the Omnibar does remove focus

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code wise.

@yaira2
Copy link
Member Author

yaira2 commented Jul 3, 2025

Thank you for the review

@yaira2 yaira2 merged commit 4646cd6 into main Jul 3, 2025
8 of 9 checks passed
@yaira2 yaira2 deleted the ya/ModeButtonFocus branch July 3, 2025 15:20
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants