Skip to content

Code Quality: Improved Omnibar 14 #17248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 4, 2025

Resolved / Related Issues

Steps used to test these changes

When I type in this box, it flashes the results screen every time I type or erase a letter. Pretty annoying. The preview version doesn't do that.

  1. Open Files app
  2. Switch modes between Path and Palette multiple times.

I think some padding for the key symbols on the command pallet should be added so it not cut off partially when the scrollbar hovered/always out states.

  1. Go to the Palette mode
  2. See the suggestions UI

One thing I noticed is the height of the mode buttons is a bit smaller

  1. See the Omnibar mode button UI

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-OmnibarSearch branch from 1fa5953 to dba4123 Compare July 4, 2025 04:58
@0x5bfa 0x5bfa changed the title Fixed an issue where the UI thread can fall into dead-lock state when switching Omnibar modes Code Quality: Improved Omnibar 14 Jul 4, 2025
@@ -445,6 +445,7 @@
<keyboard:KeyboardShortcut
x:Name="RightAlignedKeyboardShortcut"
Grid.Column="2"
Margin="0,0,8,0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be cleaner to move the margin to the containing grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants