[Draft] Add generated client files to fcm #1344
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: adding DOM to lib is necessary to make the compiler happy, but shouldn't be a runtime issue
maceonthompson
changed the title
hiranya911
reviewed
Jun 24, 2021
|
I see that you've nested So lets use the structure you currently have for now. Later we can discuss other approaches for organizing these files in our repo. |
…ly run (#1353) * Update Gulpfile to copy files required for generated code to run. * Fix introduced typo on 104 * Remove redundant glob from `copyJson()` task
This PR serves as a proof of concept to show that GAPIC generated clients can be integrated with Firebase Admin APIs. It also shows that this integration for pre-existing APIs requires a relatively substantial amount of work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Draft]
The result of moving autogenerated fcm client code using GAPIC into the messaging directory. Subsequent PRs will be made into this branch as development continues (namely, migrating to the generated client over messaging-api-request-internal.ts
This is part of an ongoing internship project/experiment in the feasibility of using autogenerated clients, which will hopefully make supporting multiple apis across multiple languages easier in the long term.