Skip to content

storage list compile error #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: feat/storage-list-stubs
Choose a base branch
from
Draft

storage list compile error #1746

wants to merge 4 commits into from

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

jonsimantov and others added 4 commits June 25, 2025 13:55
@jonsimantov
Merge remote-tracking branch 'origin/main' into feat/storage-list-stubs
397c547
@google-labs-jules
Fix: Add missing includes for ListResult
fe5f663 
Added #include "firebase/storage/list_result.h" to storage_reference.h and storage_reference_desktop.h to resolve compilation errors related to undeclared identifier 'ListResult'.
@google-labs-jules
Fix: Use StorageReference::is_valid() in assertions
6ec0081 
Changed FIREBASE_ASSERT_RETURN to use is_valid() instead of
internal_->is_valid() in StorageReference::ListAll() and
StorageReference::List() methods.

This corrects the compilation error where 'is_valid' was not a member
of the internal PIMPL class. The assertion now correctly checks the
validity of the public StorageReference object before proceeding.
@google-labs-jules
Fix: Correct include path for StorageInternal in list_result_desktop.h
97effb9 
Changed the include from 'storage_internal_desktop.h' to
'storage_desktop.h' in list_result_desktop.h.

'storage_internal_desktop.h' does not exist; 'storage_desktop.h'
contains the definition for internal::StorageInternal, which is used by
ListResultInternal. This resolves the 'file not found' compilation error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonsimantov