Skip to content

Update print_github_reviews.py to read token from ~/.github_token #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Update print_github_reviews.py to read token from ~/.github_token #1752

merged 1 commit into from
Jun 27, 2025

Conversation

jonsimantov
Copy link
Contributor

If GITHUB_TOKEN environment variable is not set and --token argument is not provided, the script will now attempt to read the GitHub token from the ~/.github_token file.

The order of precedence for token retrieval is:

  1. --token command-line argument
  2. GITHUB_TOKEN environment variable
  3. ~/.github_token file

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-labs-jules
Update print_github_reviews.py to read token from ~/.github_token
7578ece 
If GITHUB_TOKEN environment variable is not set and --token argument is not provided, the script will now attempt to read the GitHub token from the `~/.github_token` file.

The order of precedence for token retrieval is:
1. --token command-line argument
2. GITHUB_TOKEN environment variable
3. ~/.github_token file
@jonsimantov jonsimantov merged commit 2240e3c into main Jun 27, 2025
13 of 14 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2025 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 2240e3c
Last updated: Fri Jun 27 12:07 PDT 2025
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 27, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonsimantov