-
Notifications
You must be signed in to change notification settings - Fork 963
Remote Config realtime for Web #9199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
3a792c1
to
7653692
Compare
7653692
to
77a6aca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan add further tests for the realtime functionality?
Yes we will be adding the unit test cases for everything in the upcoming PR. |
* Added the visibilityMonitor * minor changes * resolving the spacing problem
This PR contains the logic for adding a new API, onConfigUpdate, for making a Realtime Connection and implementing backoff logic in case of errors. Making a connection and going into backoff is working as expected.
In follow-up PRs, we will add logic for handling tab visibility (foreground/background) to either make or close a connection based on activity, implement AutoFetch logic, and add unit tests.