Skip to content

Update readme for 12.10.1 #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Update readme for 12.10.1 #1273

merged 1 commit into from
Jun 25, 2025

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Update the readme for the upcoming bug fix release.


Testing

Describe how you've tested these changes.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from jonsimantov June 25, 2025 18:48
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the readme.md documentation to incorporate critical information for the 12.10.1 release. The changes provide clarity on Firebase's iOS AppDelegate handling, introduce a new explicit configuration option for developers, and document the latest bug fixes and features in the release notes.

Highlights

  • Documentation Update: This pull request primarily updates the readme.md file to reflect changes and new information relevant to the upcoming 12.10.1 release.
  • iOS AppDelegate Swizzling Explained: A new section titled 'Platform Notes' has been added, providing a detailed explanation of how Firebase uses method swizzling on iOS to interact with the application's AppDelegate, particularly for Firebase Cloud Messaging.
  • Explicit AppDelegate Configuration for iOS: Introduced a new configuration option allowing developers to explicitly specify their AppDelegate class name via the FirebaseAppDelegateClassName key in the app's Info.plist file. This provides an alternative to Firebase's default swizzling mechanism.
  • Release Notes for 12.10.1: The 'Release Notes' section has been updated to include entries for version 12.10.1, detailing a fix for iOS AppDelegate swizzling logic that addresses slow startup and crashes on iOS 15 (related to objc_copyClassList), and the introduction of the explicit AppDelegate class name configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README with information about the upcoming 12.10.1 release, including documentation for iOS method swizzling and corresponding release notes.

Comment on lines +70 to +72
The Firebase Cloud Messaging library needs to attach
handlers to the application delegate using method swizzling. If you are using
these libraries, at load time, Firebase will typically identify your `AppDelegate`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid potential confusion, clarify that Firebase Cloud Messaging is an example of a library that uses method swizzling. The current phrasing mentions only FCM, but then uses the plural "these libraries", which can be confusing. Also, the release notes tag this as a "General (iOS)" change, suggesting it might affect more than just FCM.

Suggested change
The Firebase Cloud Messaging library needs to attach
handlers to the application delegate using method swizzling. If you are using
these libraries, at load time, Firebase will typically identify your `AppDelegate`
Some Firebase libraries, like Cloud Messaging, need to attach
handlers to the application delegate using method swizzling. If you are using
these libraries, at load time, Firebase will typically identify your `AppDelegate`

Comment on lines +118 to +122
- General (iOS): Added an option to explicitly specify your app's `AppDelegate` class
name via the `FirebaseAppDelegateClassName` key in `Info.plist`. This
provides a more direct way for Firebase to interact with your specified
AppDelegate. See "Platform Notes > iOS Method Swizzling >
Specifying Your AppDelegate Class Directly (iOS)" for details.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider rephrasing this to be more concise, since the link provides the details. For example, "Added an option to explicitly specify your app's AppDelegate class name via the FirebaseAppDelegateClassName key in Info.plist."

Suggested change
- General (iOS): Added an option to explicitly specify your app's `AppDelegate` class
name via the `FirebaseAppDelegateClassName` key in `Info.plist`. This
provides a more direct way for Firebase to interact with your specified
AppDelegate. See "Platform Notes > iOS Method Swizzling >
Specifying Your AppDelegate Class Directly (iOS)" for details.
Added an option to explicitly specify your app's `AppDelegate` class
name via the `FirebaseAppDelegateClassName` key in `Info.plist`.

@a-maurice a-maurice merged commit c43fdca into main Jun 25, 2025
5 checks passed
@a-maurice a-maurice deleted the am-12.10.1 branch June 25, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants