Skip to content

fixed missing await keyword #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed missing await keyword #364

wants to merge 1 commit into from

Conversation

Tapesh-1308
Copy link

I have added the await keyword that was missing before the setDoc() function.

DevsOfUnify
DevsOfUnify approved these changes May 6, 2024
View reviewed changes
Copy link

@DevsOfUnify DevsOfUnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, we need await to handle the return response or errors else the functions completes its execution before the doc is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DevsOfUnify DevsOfUnify DevsOfUnify approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tapesh-1308 @DevsOfUnify