fix(test): do not use absolute path to true when opening ssh connection #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
reviewed
Dec 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4962 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 248 248
Lines 27791 27791
=======================================
Hits 23327 23327
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Manciukic
force-pushed
the
pr/fix-popular-containers
branch
from
ca0fd64 to
112f6d3
Compare
pb8o
previously approved these changes
Dec 16, 2024
In firecracker-microvm#4955 the executable to check the ssh connection liveliness was changed from `true` to `/usr/bin/true`, but that is not its path in all rootfs, causing failures in the `test-populat-containers` suite. Also, since the error is retried but the daemon is not cleaned up, subsequent retries would fail for the assertion. This change fixes both issues by using the binary name `true` and stopping the daemon on error before the next retry. Fixes: 3b2c2d4 ("test: use single SSH connection for lifetime of microvm") Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
force-pushed
the
pr/fix-popular-containers
branch
from
112f6d3 to
faeab20
Compare
roypat
approved these changes
Dec 16, 2024
pb8o
reviewed
Dec 16, 2024
pb8o
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change fixes the
test-popular-containerssuite by using the binary nametruewhen estabilishing the ssh connection instead of the absolute path, and cleaning up the ssh control socket on error before the next retry.Reason
Fixes #4955
In #4955 the executable to check the ssh connection liveliness was changed from
trueto/usr/bin/true, but that is not its path in all rootfs, causing failures in thetest-popular-containerssuite.Also, since the error is retried but the control socket is not cleaned up, subsequent retries would fail for the assertion.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.