Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: print EC2 AMI in the pytest report header #4976

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Dec 30, 2024

Changes

Print the EC2 AMI in the pytest report header.

Reason

To easily tell which AMI is being used, for validation or troubleshooting

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed python Pull requests that update Python code labels Dec 30, 2024
@pb8o pb8o self-assigned this Dec 30, 2024
@pb8o pb8o requested a review from kalyazin December 30, 2024 15:28
tests/conftest.py Show resolved Hide resolved
This is useful for validation tasks and when troubleshooting.

Signed-off-by: Pablo Barbáchano <[email protected]>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.93%. Comparing base (5b706ed) to head (b418870).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4976   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files         248      248           
  Lines       27791    27791           
=======================================
  Hits        23327    23327           
  Misses       4464     4464           
Flag Coverage Δ
5.10-c5n.metal 84.51% <ø> (ø)
5.10-m5n.metal 84.49% <ø> (ø)
5.10-m6a.metal 83.78% <ø> (ø)
5.10-m6g.metal 80.61% <ø> (ø)
5.10-m6i.metal 84.49% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 80.61% <ø> (ø)
6.1-c5n.metal 84.51% <ø> (ø)
6.1-m5n.metal 84.49% <ø> (ø)
6.1-m6a.metal 83.78% <ø> (-0.01%) ⬇️
6.1-m6g.metal 80.60% <ø> (-0.01%) ⬇️
6.1-m6i.metal 84.49% <ø> (+<0.01%) ⬆️
6.1-m7g.metal 80.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zulinx86 zulinx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is acceptable that external contributors can see the ID from the public buildkite pipeline log? I know they are private AMIs and basically don't include secrets, but just to confirm.

@pb8o
Copy link
Contributor Author

pb8o commented Jan 2, 2025

So it is acceptable that external contributors can see the ID from the public buildkite pipeline log? I know they are private AMIs and basically don't include secrets, but just to confirm.

Yeah I think it is OK since the AMI is not shared and is an opaque identifier.

@pb8o pb8o merged commit e70bfab into firecracker-microvm:main Jan 2, 2025
7 checks passed
@pb8o pb8o deleted the ci-print-ami branch January 2, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` python Pull requests that update Python code Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants