test: unpin m6i/5.10 AMI for perf tests #4983
Merged
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With C-states renabled by f610cae ("fix: stop messing with C-states in performance tests"), the m6i volatility will be gone. Signed-off-by: Patrick Roy <[email protected]>
pb8o
previously approved these changes
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4983 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 248 248
Lines 27839 27839
=======================================
Hits 23371 23371
Misses 4468 4468
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Using the larger delay appears to have negative side affects on AMD Signed-off-by: Jack Thomson <[email protected]>
Manciukic
approved these changes
Jan 8, 2025
zulinx86
approved these changes
Jan 9, 2025
JackThomson2
reviewed
Jan 9, 2025
JackThomson2
approved these changes
Jan 9, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With C-states renabled by f610cae ("fix: stop messing with C-states in performance tests"), the m6i volatility will be gone.
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.