Fix exception

fjohansen · Mar 21, 2024 · 61005fc · 61005fc
1 parent 189f3f6
commit 61005fc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Code/Converters/SmiConverter.php b/src/Code/Converters/SmiConverter.php
@@ -163,6 +163,10 @@ public function internalFormatToFileContent(array $internal_format , array $opti
      */
     protected static function timeToInternal($format_time)
     {
+        $format_time = str_replace('ms', '', $format_time);
+        if (!is_numeric($format_time)) {
+            throw new \Exception('Not numeric: ' . $format_time);
+        }
         $time = $format_time / 1000;
         if ($time < 0) {
             $time = 0;

diff --git a/tests/formats/SmiTest.php b/tests/formats/SmiTest.php
@@ -73,6 +73,21 @@ public function testNegativeTime()
         $this->assertInternalFormatsEqual($expected, $actual);
     }
 
+    public function testMsNearTimestamp()
+    {
+        $actual = Subtitles::loadFromString('
+<SAMI>
+<BODY>
+<SYNC Start="1000ms"><P Class=ENUSCC>a</P></SYNC>
+</BODY>
+</SAMI>
+        ')->getInternalFormat();
+        $expected = (new Subtitles())
+            ->add(1, 2, 'a')
+            ->getInternalFormat();
+        $this->assertInternalFormatsEqual($expected, $actual);
+    }
+
     public function testNoP()
     {
         $actual = Subtitles::loadFromString('