Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(notifications): Fix regression from spinnaker#3280 (spinnaker#3284)
spinnaker#3280 introduced a regression where if there are multiple notifications and the exeuction has SCM info (e.g. jenkins trigger) the pipeline notifications won't get sent out. Why you ask? Side-effects, my friends! `contextParameterProcessor.process` actually MUTATES the context that is passed in (it extracts the scm info which starts out as a list and then replaces it with an actual SourceControl object :mindblown:) see https://github.com/spinnaker/orca/blob/master/orca-core/src/main/java/com/netflix/spinnaker/orca/pipeline/util/ContextParameterProcessor.java#L170 I wanted to not jackson map the whole execution every single notification we eval so I cached and there-in lay my mistake... This change, does not reuse the executionContext map avoiding this problem
- Loading branch information