Skip to content

Commit

Permalink
test/docker-test: drop support for ubuntu 14.04 and centos 6
Browse files Browse the repository at this point in the history
* we cannot build on centos 6. and we are dropping the support for ubuntu
  14.04 also.
* add ubuntu 17.04: this release is not a LTS release, and added merely for
  demostration purpose.

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov committed Dec 4, 2017
1 parent dbe3350 commit 1acfa03
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 79 deletions.
30 changes: 0 additions & 30 deletions src/test/centos-6/Dockerfile.in

This file was deleted.

1 change: 0 additions & 1 deletion src/test/centos-6/ceph.spec.in

This file was deleted.

21 changes: 10 additions & 11 deletions src/test/docker-test-helper.sh
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ $0 [options] command args ...
[--os-type type] docker image repository (centos, ubuntu, etc.)
(defaults to ubuntu)
[--os-version version] docker image tag (7 for centos, 12.04 for ubuntu, etc.)
(defaults to 14.04)
[--os-version version] docker image tag (7 for centos, 16.04 for ubuntu, etc.)
(defaults to 16.04)
[--ref gitref] git reset --hard gitref before running the command
(defaults to git rev-parse HEAD)
[--all types+versions] list of docker image repositories and tags
Expand All @@ -171,7 +171,7 @@ continues. Here is a sample use case including an interactive session
and running a unit test:
$ lsb_release -d
Description: Ubuntu Trusty Tahr (development branch)
Description: Ubuntu Xenial Xerus (development branch)
$ test/docker-test.sh --os-type centos --os-version 7 --shell
HEAD is now at 1caee81 autotools: add --enable-docker
bash-4.2$ pwd
Expand Down Expand Up @@ -202,21 +202,20 @@ and running a unit test:
The --all argument is a bash associative array literal listing the
operating system version for each operating system type. For instance
docker-test.sh --all '([ubuntu]="12.04 14.04" [centos]="6 7")'
docker-test.sh --all '([ubuntu]="16.04 17.04" [centos]="7")'
is strictly equivalent to
docker-test.sh --os-type ubuntu --os-version 12.04
docker-test.sh --os-type ubuntu --os-version 14.04
docker-test.sh --os-type centos --os-version 6
docker-test.sh --os-type ubuntu --os-version 16.04
docker-test.sh --os-type ubuntu --os-version 17.04
docker-test.sh --os-type centos --os-version 7
The --os-type and --os-version must be exactly as displayed by docker images:
$ docker images
REPOSITORY TAG IMAGE ID ...
centos 7 87e5b6b3ccc1 ...
ubuntu 14.04 6b4e8a7373fe ...
ubuntu 16.04 6b4e8a7373fe ...
The --os-type value can be any string in the REPOSITORY column, the --os-version
can be any string in the TAG column.
Expand All @@ -232,8 +231,8 @@ docker-test.sh --ref giant -- make check
Run an interactive shell and set resolv.conf to use 172.17.42.1
docker-test.sh --opts --dns=172.17.42.1 --shell
Run make check on centos 6, centos 7, ubuntu 12.04 and ubuntu 14.04
docker-test.sh --all '([ubuntu]="12.04 14.04" [centos]="6 7")' -- make check
Run make check on centos 7, ubuntu 16.04 and ubuntu 17.04
docker-test.sh --all '([ubuntu]="16.04 17.04" [centos]="7")' -- make check
EOF
}

Expand All @@ -249,7 +248,7 @@ function main_docker() {
eval set -- "$temp"

local os_type=ubuntu
local os_version=14.04
local os_version=16.04
local all
local remove=false
local shell=false
Expand Down
31 changes: 0 additions & 31 deletions src/test/ubuntu-12.04/Dockerfile.in

This file was deleted.

1 change: 0 additions & 1 deletion src/test/ubuntu-12.04/debian

This file was deleted.

1 change: 0 additions & 1 deletion src/test/ubuntu-12.04/install-deps.sh

This file was deleted.

1 change: 0 additions & 1 deletion src/test/ubuntu-14.04/debian

This file was deleted.

1 change: 0 additions & 1 deletion src/test/ubuntu-14.04/install-deps.sh

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright (C) 2014, 2015 Red Hat <[email protected]>
# Copyright (C) 2016 Red Hat <[email protected]>
#
# Author: Loic Dachary <[email protected]>
#
Expand Down Expand Up @@ -27,5 +27,5 @@ RUN apt-get update
# build dependencies
RUN cd /root ; ./install-deps.sh
# development tools
RUN apt-get install -y ccache valgrind gdb python-virtualenv gdisk kpartx jq xmlstarlet
RUN apt-get install -y ccache valgrind gdb python-virtualenv gdisk kpartx jq xmlstarlet sudo
RUN if test %%USER%% != root ; then useradd -M --uid %%user_id%% %%USER%% && echo '%%USER%% ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers ; fi
1 change: 1 addition & 0 deletions src/test/ubuntu-17.04/debian
File renamed without changes.

0 comments on commit 1acfa03

Please sign in to comment.