Non mempool profit #621
Merged
Non mempool profit #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvush
approved these changes
May 19, 2025
crates/rbuilder/src/building/mod.rs
Outdated
| } else { | ||
| error!( | ||
| non_mempool_coinbase_profit = format_ether(non_mempool_coinbase_profit), | ||
| "Non mempool orders have always positive profit, how did we got a negative value????"); |
There was a problem hiding this comment.
can you please rewrite the message to make it more boring and uniform
| /// Current implementation is super simple, it just checks the tx hash against a set of hashes. | ||
| #[derive(Debug)] | ||
| pub struct MempoolTxsDetector { | ||
| mempool_txs: Mutex<HashSet<TxHash>>, |
There was a problem hiding this comment.
I think its always better to use something that has lower chance of blocking:
DashSet > RwLock<HashSet> > Mutex<HashSet>
since we use dashmap here a lot, DashSet is a great choice (but don't forget to specify ahash as a hasher instead of default hasher)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
SimValue now has 2 ProfitInfo instead of the single coinbase_profit/gas_used pair so now we have the full_profit_info (previous coinbase_profit/gas_used) and the new non_mempool_profit_info which excludes mempool txs profits from bundles.
Backwards compatible.
Implementation to detect mempool tx is super simple and heavily assumes that we will always see a mempool tx before a bundle including that tx:
We add a order_input::mempool_txs_detector::ReplaceableOrderStreamSniffer in the orderflow stream that updates the MempoolTxsDetector which is used on SimValue creation to filter mempool txs.
💡 Motivation and Context
This will give more info to block building algorithms.
✅ I have completed the following steps:
make lintmake test