Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleetd can now download software installers from signed CDN URLs. #25276

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Jan 8, 2025

For #24870 subtask

API changes doc: #25293

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated automated tests
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 49.52381% with 106 lines in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (cbe44ee) to head (f368d7e).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
server/service/orbit_client.go 0.00% 36 Missing ⚠️
cmd/fleet/serve.go 0.00% 16 Missing ⚠️
server/worker/apple_mdm.go 62.50% 10 Missing and 2 partials ⚠️
server/service/base_client.go 0.00% 10 Missing ⚠️
server/datastore/s3/common_file_store.go 35.71% 6 Missing and 3 partials ⚠️
server/config/config.go 63.15% 6 Missing and 1 partial ⚠️
cmd/fleet/cron.go 0.00% 4 Missing ⚠️
ee/server/service/software_installers.go 91.89% 2 Missing and 1 partial ⚠️
orbit/pkg/installer/installer.go 81.25% 2 Missing and 1 partial ⚠️
server/datastore/filesystem/software_installer.go 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25276      +/-   ##
==========================================
- Coverage   63.85%   63.84%   -0.01%     
==========================================
  Files        1616     1616              
  Lines      153833   154000     +167     
  Branches     3975     3975              
==========================================
+ Hits        98224    98317      +93     
- Misses      47795    47860      +65     
- Partials     7814     7823       +9     
Flag Coverage Δ
backend 64.71% <49.52%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor marked this pull request as ready for review January 9, 2025 18:00
@getvictor getvictor requested a review from a team as a code owner January 9, 2025 18:00
@lucasmrod
Copy link
Member

Friendly reminder orbit changes are on freeze.

@georgekarrv georgekarrv marked this pull request as draft January 14, 2025 17:44
@georgekarrv
Copy link
Member

Converted to draft to hold it over until it can merge after the orbit freeze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants