fix: correct parameter order in a parseTextStyle function call
#5566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes incorrect parameter order in a parseTextStyle function call as indicated by issue #5565. The fix corrects the order of parameters from (theme, jv) to (jv, theme) to match the expected function signature.
- Corrected parameter order in
parseTextStylefunction call - Reorganized Python development tasks to improve clarity and usability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/flet/lib/src/utils/text.dart | Fixed parameter order in parseTextStyle function call |
| sdk/python/Taskfile.yml | Reorganized task names and added aliases for better development workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Could you add an integration test for the fixed case please? |
Deploying flet-docs with
|
| Latest commit: |
1be2803
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://abf84e79.flet-docs.pages.dev |
| Branch Preview URL: | https://fix-button.flet-docs.pages.dev |
FeodorFitsner
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5565
Summary by Sourcery
Fix parseTextStyle parameter order and reorganize Python SDK Taskfile tasks for improved clarity
Bug Fixes:
Enhancements:
pyproject-setuptoinstall, renameteststounit-tests, and introduceintegration-testsandcontrol-integration-testswith standardized aliases