Skip to content

Commit

Permalink
Adds direction to SemanticsFlag that ensures flutter_test is up to …
Browse files Browse the repository at this point in the history
…date with the latest flags (#37046)
  • Loading branch information
pdblasi-google authored Oct 26, 2022
1 parent 20b4b62 commit 91c8221
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions lib/ui/semantics.dart
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ class SemanticsAction {
//
// When changes are made to this class, the equivalent APIs in
// `lib/ui/semantics/semantics_node.h` and in each of the embedders *must* be
// updated.
// updated. If the change affects the visibility of a [SemanticsNode] to
// accessibility services, `flutter_test/controller.dart#SemanticsController._importantFlags`
// must be updated as well.
class SemanticsFlag {
const SemanticsFlag._(this.index) : assert(index != null);

Expand Down Expand Up @@ -324,7 +326,10 @@ class SemanticsFlag {
// value in testing/dart/semantics_test.dart, or tests will fail. Also,
// please update the Flag enum in
// flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java,
// and the SemanticsFlag class in lib/web_ui/lib/semantics.dart.
// and the SemanticsFlag class in lib/web_ui/lib/semantics.dart. If the new flag
// affects the visibility of a [SemanticsNode] to accessibility services,
// `flutter_test/controller.dart#SemanticsController._importantFlags`
// must be updated as well.

/// The semantics node has the quality of either being "checked" or "unchecked".
///
Expand Down

0 comments on commit 91c8221

Please sign in to comment.