Skip to content

[fix] RestartFlutterDaemonAction menu item rendering in the device selector #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pq
Copy link
Contributor

@pq pq commented Jun 12, 2025

Programmatic invocation of the default constructor was creating an instance that didn't have the benefit of having text and icon set by the plugin.xml contribution. This adds a new "factory" method (kinda) for dynamic creations.

image

Fixes: #8264


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested review from jwren and helin24 June 12, 2025 21:48
@pq pq merged commit 49e585b into flutter:master Jun 12, 2025
7 checks passed
@pq pq deleted the fix_RestartFlutterDaemonAction_menuPresentation branch June 12, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty menu item in the flutter device selector
3 participants