Skip to content

[CQ] fix nullability problems for flutter/actions #8293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented Jun 27, 2025

Fix nullability problems for all the actions in src/io/flutter/actions/.

See #8291.

If we pursue #8292, we could mark src/io/flutter/actions/ as null-"clean".


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested review from jwren and helin24 June 27, 2025 17:16
Copy link
Member

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the DataFlowIssue marker? Is it usually this situation in our code? https://stackoverflow.com/questions/76761165/how-to-supress-nullpointer-warning-in-intellij

@pq
Copy link
Contributor Author

pq commented Jun 27, 2025

Exactly. It's really unfortunate that the label is so general. It'd be way more useful IMO if it said "nullability issue" or similar.

As a rule, I try and avoid using it but in some cases (when for example, you're interacting w/ unannotated libraries) there's not a great alternative. (I'm on the fence about whether asserts are any better or just add more noise.)

FWIW: if we ever do get to a null-safe world, I'd love to do another round of cleanup that evaluates all the suppressions and cleans them up.

That may be majorly wishful thinking though!

@pq pq merged commit dd99416 into flutter:master Jun 27, 2025
8 checks passed
@pq pq deleted the cq_nullability_flutterActions branch June 27, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants