Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration guide for InputDecoration.maintainHintHeight deprecation #11742

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Migration guide for InputDecoration.maintainHintHeight deprecation #11742

merged 2 commits into from
Feb 28, 2025
+80 −0

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Feb 25, 2025

This PR adds a migration guide for inputDecoration.maintainHintHeight.

Related PRs:

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@bleroux bleroux requested review from sfshaza2, antfitch, parlough and a team as code owners February 25, 2025 15:31
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Feb 25, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit edd48e3):

https://flutter-docs-prod--pr11742-deprecate-inputdecoration-m-zaulrwa1.web.app

@antfitch
Copy link
Contributor

Reviewing...

antfitch
antfitch reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few small changes are needed.

@bleroux bleroux force-pushed the deprecate_InputDecoration.maintainHintHeight branch from fbd059a to 91779a9 Compare February 26, 2025 13:09
@bleroux bleroux force-pushed the deprecate_InputDecoration.maintainHintHeight branch from 91779a9 to edd48e3 Compare February 26, 2025 13:20
@antfitch antfitch merged commit 2d6d06b into flutter:main Feb 28, 2025
9 checks passed
@bleroux bleroux deleted the deprecate_InputDecoration.maintainHintHeight branch February 28, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfitch antfitch antfitch approved these changes

@sfshaza2 sfshaza2 Awaiting requested review from sfshaza2 sfshaza2 is a code owner

@parlough parlough Awaiting requested review from parlough parlough is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bleroux @flutter-website-bot @antfitch