Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [el-radio] [API] label act as value is about to be deprecated in… #48

Closed
wants to merge 1 commit into from
Closed

Conversation

SorrowX
Copy link
Contributor

@SorrowX SorrowX commented Jul 2, 2024

… version 3.0.0

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from main or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for formily-element-plus failed.

Name Link
🔨 Latest commit a17c7c8
🔍 Latest deploy log https://app.netlify.com/sites/formily-element-plus/deploys/66839564c1e6250008b0a362

@SorrowX
Copy link
Contributor Author

SorrowX commented Jul 2, 2024

问题: ElementPlusError: [el-radio] [API] label act as value is about to be deprecated in version 3.0.0, please use value instead.
For more detail

  1. 警告提示
  2. 修复radio插槽问题,el-radio只有default插槽,所以我们应该使用default插槽而非option插槽

解决:上述pr已修复,大佬有时间仔细审查

@SorrowX
Copy link
Contributor Author

SorrowX commented Jul 2, 2024

有人修改了配置,导致构建失败

@SorrowX SorrowX closed this by deleting the head repository Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant