Hashmap test update #1025
Open
Hashmap test update #1025
+520
−618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactor of the main hashmap test routine to improve coverage and simplify the code. The fypp preprocessor directives have been removed to make the code easier to work with and modify for future releases.
Addressed 132 character limit issues.
Minor cleanup
Add example of using abstract hashmap_type for procedure interrface.
|
This PR also makes the abstract hashmap_type public so that can be used for interface definition that works for both open and chaining types. I thought it was worth adding a simple example showing the use of that. |
jvdp1
reviewed
Aug 30, 2025
| ! This allows the procedure to be used for both chaining and open hashmap types. | ||
|
|
||
| program example_abstract_type | ||
| use stdlib_kinds, only: int8, int64 |
There was a problem hiding this comment.
Suggested change
| use stdlib_kinds, only: int8, int64 |
Both are not used in this example
| @@ -0,0 +1,53 @@ | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
Nice suggestion to make hashmap_type public
Could you update the specs, too, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of development work on the stdlib hashmaps, I have run into CI failures on the stdlib test that I'm not sure if it's due to code updates, or because of format of hashmap test program. For example, the way the current implantation uses transfer to generate character values, I'm not sure it's always generating valid character values. Also fypp makes it harder to develop and update the test routine as the hashmaps evolve.
This PR is an attempt to address those shortcomings. The intent is to improve test coverage of hashmap functions, improve test quality (ensure valid data is being used for key and values), and simplify the code and remove fypp preprocessor format.