more lenient string to boolean casting

fortunejs · Jul 30, 2017 · dd91315 · dd91315
1 parent 6c8d7ad
commit dd91315
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Changelog
 
 
+### 5.2.11 (2017-07-30)
+- Polish: more lenient type casting of string to boolean, to accept more variants of truthy values.
+- Polish: fix test setup regarding message not being injected into adapter.
+
+
 ### 5.2.10 (2017-07-29)
 - Polish: each instance contains a copy of the message function, to avoid overwriting the global message.
 

diff --git a/lib/common/cast_value.js b/lib/common/cast_value.js
@@ -39,7 +39,8 @@ var castByType = [
   } ],
 
   [ Boolean, function (x) {
-    if (typeof x === 'string') return x === 'true'
+    if (typeof x === 'string')
+      return (/^(?:true|1|yes|t|y)$/i).test(x)
     return Boolean(x)
   } ],
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "fortune",
   "description": "Database abstraction layer that implements common features for Node.js and web browsers.",
-  "version": "5.2.10",
+  "version": "5.2.11",
   "license": "MIT",
   "homepage": "http://fortune.js.org",
   "repository": {

diff --git a/test/unit/adapter.js b/test/unit/adapter.js
@@ -775,6 +775,7 @@ function runTest (adapterFn, options, fn) {
   try {
     adapter = new AdapterSingleton({
       recordTypes,
+      message,
       adapter: [ adapterFn, options ]
     })
   }