Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added form-data and contentType from the Curl parser that got updated #505

Merged
merged 12 commits into from
Dec 5, 2024

Conversation

WrathOP
Copy link
Contributor

@WrathOP WrathOP commented Nov 30, 2024

PR Description

Now storing the form-data in the httpRequestModel too.

Just tell me if you want to alter/remove the logic for content-type.

Related Issues

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • Yes
  • No, and this is why: Just passing on the already tested code's variable to the model.

OS on which you have developed and tested the feature?

  • Windows
  • macOS
  • Linux

@ashitaprasad
Copy link
Member

Open an issue and link this PR.

@ashitaprasad
Copy link
Member

Kindly add tests verifying given a curl string correct HttpRequestModel is being obtained.

@WrathOP
Copy link
Contributor Author

WrathOP commented Dec 5, 2024

Sorry for the delays was busy, added the tests you asked for.

@ashitaprasad
Copy link
Member

Thanks for the PR @WrathOP 🚀
Now that you are a curl-master, definitely looking forward to you attacking Hurl! ( #123)

@ashitaprasad ashitaprasad merged commit 5ece558 into foss42:main Dec 5, 2024
@WrathOP
Copy link
Contributor Author

WrathOP commented Dec 6, 2024

Thanks for the PR @WrathOP 🚀

Now that you are a curl-master, definitely looking forward to you attacking Hurl! ( #123)

Sure will work in it, heard about HURL for first time though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form-data and contentType from the Curl parser
2 participants