Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed display problem in "Featured Designers" #177

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Fixed display problem in "Featured Designers" #177

wants to merge 1 commit into from

Conversation

geethmaka
Copy link

@geethmaka geethmaka commented Oct 24, 2018 •
edited
Loading

Fixed display issue in Featured Designers part

NaviRocker
NaviRocker suggested changes Oct 24, 2018
View reviewed changes
Copy link
Member

@NaviRocker NaviRocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Provide a Description and a Preview Link

@NaviRocker
Copy link
Member

For more details, Follow the Contributor Best Practices.

NaviRocker
NaviRocker approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@NaviRocker NaviRocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Fine for me. Hereafter try to produce a preview link along with the PR. And include the Issue which you are solving.

simsausaurabh
simsausaurabh suggested changes Oct 26, 2018
View reviewed changes
Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue for every problem you are fixing, and reference the issue in your commit message/PR-description. Also provide screenshot or preview link to check your changes. Thanks 👍

@mariobehling
Copy link
Member

Please resolve conflicts

abishekvashok
abishekvashok suggested changes Dec 6, 2018
View reviewed changes
Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unwanted blank lines

samagragupta
samagragupta suggested changes Dec 8, 2018
View reviewed changes
Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samagragupta samagragupta samagragupta requested changes

@simsausaurabh simsausaurabh simsausaurabh requested changes

@abishekvashok abishekvashok abishekvashok requested changes

@NaviRocker NaviRocker NaviRocker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geethmaka @NaviRocker @mariobehling @abishekvashok @simsausaurabh @samagragupta