Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#198)Added ReadMore feature to Designers #209

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

saarthakchats
Copy link
Member

@saarthakchats saarthakchats commented Dec 10, 2018

Added feature that improves look and style of the designers' section(also saves space-- temporarily)
Fixes #198
Preview Link

Before

screenshot 2018-12-05 at 11 51 28 am

After

screenshot 2018-12-10 at 8 29 44 am

screenshot 2018-12-10 at 8 29 44 am

@saarthakchats
Copy link
Member Author

saarthakchats commented Dec 10, 2018

I understand that this might not be the most effiecient way to do this but after trying out 3-4 methods, this for me is the only reliable way through which the function works perfectly.
Please review and merge.. thanks 😄

Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a single function with parameters. Reliability would be the same.

@saarthakchats
Copy link
Member Author

I tried earlier, but it doesn't work for me.. a lot of problems were occuring

@saarthakchats saarthakchats force-pushed the gh-pages branch 2 times, most recently from 5fdcfe5 to 3660574 Compare December 10, 2018 05:32
@saarthakchats
Copy link
Member Author

Done @abishekvashok
It finally did work for me 👍

he is
all at once? In the last few years, Pierre contributed to the development of major
Free
Software projects such as the Scribus desktop publishing software. He is
projectleader
of FontMatrix, a font management system initiated in 2007. He works on the duo
of FontMatrix, a font management system initiated in<span id="dots1">...</span><span id="more1"> 2007. He works on the duo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@abishekvashok abishekvashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider the comment by @pythongiant

} else if (number == 3) {
var dots = document.getElementById("dots3");
var moreText = document.getElementById("more3");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Append the number to the IDs and reduce the ifs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, I failed terribly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't fail, please do it correctly.

@saarthakchats
Copy link
Member Author

@pythongiant I'm using the 'dots' as id to pull so I can do without the ellipsis

@pythongiant
Copy link
Member

That is just more complicated and not required. moreover, it slows the website.

@pythongiant I'm using the 'dots' as id to pull so I can do without the ellipsis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants