-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#198)Added ReadMore feature to Designers #209
base: gh-pages
Are you sure you want to change the base?
Conversation
I understand that this might not be the most effiecient way to do this but after trying out 3-4 methods, this for me is the only reliable way through which the function works perfectly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a single function with parameters. Reliability would be the same.
I tried earlier, but it doesn't work for me.. a lot of problems were occuring |
5fdcfe5
to
3660574
Compare
3660574
to
2ea9c2c
Compare
Done @abishekvashok |
he is | ||
all at once? In the last few years, Pierre contributed to the development of major | ||
Free | ||
Software projects such as the Scribus desktop publishing software. He is | ||
projectleader | ||
of FontMatrix, a font management system initiated in 2007. He works on the duo | ||
of FontMatrix, a font management system initiated in<span id="dots1">...</span><span id="more1"> 2007. He works on the duo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also consider the comment by @pythongiant
} else if (number == 3) { | ||
var dots = document.getElementById("dots3"); | ||
var moreText = document.getElementById("more3"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Append the number to the IDs and reduce the ifs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that, I failed terribly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't fail, please do it correctly.
@pythongiant I'm using the 'dots' as id to pull so I can do without the ellipsis |
That is just more complicated and not required. moreover, it slows the website.
|
Added feature that improves look and style of the designers' section(also saves space-- temporarily)
Fixes #198
Preview Link
Before
After