Skip to content

Commit

Permalink
ESLint for TypeScript (no TSLint): book/1-end/app
Browse files Browse the repository at this point in the history
  • Loading branch information
tima101 committed Oct 20, 2019
1 parent cbd8956 commit bff323b
Show file tree
Hide file tree
Showing 8 changed files with 53 additions and 349 deletions.
2 changes: 1 addition & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"recommendations": ["dbaeumer.vscode-eslint", "esbenp.prettier-vscode"]
"recommendations": ["dbaeumer.vscode-eslint"]
}
18 changes: 9 additions & 9 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@
"**/.next": true,
"**/.coverage": true
},
"editor.defaultFormatter": "dbaeumer.vscode-eslint",
"editor.formatOnSave": true,
"eslint.enable": true,
"eslint.alwaysShowStatus": true,
"eslint.autoFixOnSave": true,
"eslint.validate": [
"javascript",
"javascriptreact",
{
"autoFix": true,
"language": "typescript"
},
{
"autoFix": true,
"language": "typescriptreact"
}
]
{ "language": "typescript", "autoFix": true },
{ "language": "typescriptreact", "autoFix": true }
],
"eslint.workingDirectories": [
{ "directory": "./book/1-end/app", "changeProcessCWD": true },
]
}
55 changes: 17 additions & 38 deletions book/1-end/app/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,46 +1,25 @@
module.exports = {
parser: '@typescript-eslint/parser',
plugins: ['@typescript-eslint', 'react', 'prettier'],
extends: [
'airbnb',
'prettier',
'prettier/react',
'prettier/@typescript-eslint',
'plugin:react/recommended',
'plugin:@typescript-eslint/recommended',
],
parser: "@typescript-eslint/parser",
extends: ["plugin:@typescript-eslint/recommended", "prettier"],
env: {
es6: true,
browser: true,
jest: true,
"es6": true,
"node": true
},
rules: {
'prettier/prettier': 'error',
'max-len': ['error', 100],
'no-underscore-dangle': ['error', { allow: ['_id'] }],
'no-mixed-operators': 'off',
'prefer-destructuring': [
'prettier/prettier': [
'error',
{
VariableDeclarator: {
array: false,
object: true,
},
AssignmentExpression: {
array: true,
object: false,
},
},
{
enforceForRenamedProperties: false,
singleQuote: true,
trailingComma: 'all',
arrowParens: 'always',
printWidth: 100,
semi: true
},
],
'import/prefer-default-export': 'off',
'jsx-a11y/anchor-is-valid': 'off',
'react/react-in-jsx-scope': 'off',
'react/jsx-filename-extension': [1, { extensions: ['tsx'] }],
'@typescript-eslint/explicit-function-return-type': 'off',
'@typescript-eslint/explicit-member-accessibility': 'off',
},
overrides: [],
};
'@typescript-eslint/no-unused-vars': 'off',
'@typescript-eslint/explicit-function-return-type': 'off'
},
plugins: [
"prettier"
]
}
7 changes: 0 additions & 7 deletions book/1-end/app/.prettierrc.js

This file was deleted.

5 changes: 0 additions & 5 deletions book/1-end/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,8 @@
"@typescript-eslint/eslint-plugin": "^2.4.0",
"@typescript-eslint/parser": "^2.4.0",
"eslint": "^6.5.1",
"eslint-config-airbnb": "^18.0.1",
"eslint-config-prettier": "^6.4.0",
"eslint-plugin-import": "^2.18.2",
"eslint-plugin-jsx-a11y": "^6.2.3",
"eslint-plugin-prettier": "^3.1.1",
"eslint-plugin-react": "^7.16.0",
"eslint-plugin-react-hooks": "^2.1.2",
"prettier": "^1.18.2"
}
}
4 changes: 2 additions & 2 deletions book/1-end/app/pages/_document.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ class MyDocument extends Document {
return (
<Html lang="en">
<Head>
<meta charSet="utf-8" />{' '}
<meta name="viewport" content="width=device-width, initial-scale=1.0" />{' '}
<meta charSet="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="google" content="notranslate" />
<meta name="theme-color" content="#303030" />
</Head>
Expand Down
Loading

0 comments on commit bff323b

Please sign in to comment.