Add user-initiated rollback #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detsch
force-pushed
the
detsch-user-rollback
branch
from
3b57c51 to
2cc18d1
Compare
|
Still missing handling of bootloader rollback protection. If enabled, we should not allow rollback after update is finalized. |
mike-sul
reviewed
Dec 20, 2024
|
LGTM, will test it a bit. |
detsch
force-pushed
the
detsch-user-rollback
branch
from
2cc18d1 to
a974c91
Compare
mike-sul
reviewed
Jan 3, 2025
mike-sul
reviewed
Jan 3, 2025
mike-sul
reviewed
Jan 3, 2025
mike-sul
reviewed
Jan 3, 2025
mike-sul
reviewed
Jan 3, 2025
mike-sul
reviewed
Jan 3, 2025
mike-sul
reviewed
Jan 3, 2025
src/liteclient.cc
Outdated
|
|
||
| Uptane::Target rollback_target{Uptane::Target::Unknown()}; | ||
| { | ||
| std::vector<Uptane::Target> installed_versions; | ||
| storage->loadPrimaryInstallationLog(&installed_versions, | ||
| true /* make sure that Target has been successfully installed */); | ||
| true /* make sure that Target has been successfully installed */, false); |
There was a problem hiding this comment.
The same question about considering the current target as the target to rollback to under certain circumstances.
There was a problem hiding this comment.
A change here is probably needed, to allow current depending if the latest install has finished or not. I'll adjust it tomorrow.
mike-sul
reviewed
Jan 3, 2025
mike-sul
reviewed
Jan 3, 2025
|
LGTM, the direction is fine. I just have two concerns:
|
detsch
force-pushed
the
detsch-user-rollback
branch
3 times, most recently
from
3fec0a3 to
bba8f3f
Compare
detsch
force-pushed
the
detsch-user-rollback
branch
5 times, most recently
from
ad34f29 to
e456ee7
Compare
mike-sul
reviewed
Jan 16, 2025
mike-sul
reviewed
Jan 16, 2025
mike-sul
reviewed
Jan 16, 2025
mike-sul
reviewed
Jan 16, 2025
mike-sul
reviewed
Jan 16, 2025
mike-sul
reviewed
Jan 16, 2025
mike-sul
approved these changes
Jan 16, 2025
detsch
force-pushed
the
detsch-user-rollback
branch
2 times, most recently
from
2565cbb to
1473d8b
Compare
mike-sul
approved these changes
Jan 16, 2025
detsch
force-pushed
the
detsch-user-rollback
branch
from
1473d8b to
52168f2
Compare
mike-sul
approved these changes
Jan 21, 2025
detsch
force-pushed
the
detsch-user-rollback
branch
from
52168f2 to
3ffd0fd
Compare
This new operation marks the current target as a failing target, and proceeds to install the selected rollback target, which can be automatically selected (the most recent fully installed target), or explicitly defined by the caller of the function. A rollback can be initiated after an installation is completed, but also while finalization of system reboot is still pending. Signed-off-by: Andre Detsch <[email protected]>
Signed-off-by: Andre Detsch <[email protected]>
Signed-off-by: Andre Detsch <[email protected]>
detsch
force-pushed
the
detsch-user-rollback
branch
from
3ffd0fd to
4c0a1cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.