api: Prevent downgrade operations to be done automatically #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the latest available target has a version lower than the target that is currently running, we may or not accept it as a valid update to be performed. Before this commit, aktualizr-lite would automatically select such target and proceed with the update operation. After this commit, the target is not longer selected by default as a valid update target. It is possible to revert the behavior to the original one by defining ACCEPT_LOWER_VERSION at build time. Signed-off-by: Andre Detsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the latest available target has a version lower than the target that is currently running, we may or not accept it as a valid update to be performed.
Before this commit, aktualizr-lite would automatically select such target and proceed with the update operation. After this commit, the target is not longer selected by default as a valid update target.
It is possible to revert the behavior to the original one by defining ACCEPT_LOWER_VERSION at build time.
@mike-sul in order to keep original aklite-offline behavior, I had to keep the
force_downgradeparameter, and add a new one incli::methods. Using this new parameter we can easily add a command line option for CLI commands. But in order to avoid having users rely too much on automatic downgrades, it seems better to not have those command line options for now.