Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update photo-browser.js, add ofText config option #140

Merged
merged 2 commits into from
Jul 30, 2014
Merged

update photo-browser.js, add ofText config option #140

merged 2 commits into from
Jul 30, 2014

Conversation

boynet
Copy link
Contributor

@boynet boynet commented Jul 30, 2014

add the config option to change the 'of' word on the navbar.

add the config option to change the 'of' word on the navbar.
to give the option to other language
@nolimits4web
Copy link
Member

There is a "navbarTemplate" parameter that allows flexible customisation of this. But it is ok, could be useful and faster way. There is only note is that you've forgot the spaces around "of". Add them here:

</span> ' + pb.params.ofText + ' <span

@boynet
Copy link
Contributor Author

boynet commented Jul 30, 2014

I think its important because of two reasons:

  1. in RTL it look like this: "of 1 3"
  2. my all app is in another languge except that 'of' word so its look weird, i know that i can make my own template but it feels not good to create my own just for that word

nolimits4web added a commit that referenced this pull request Jul 30, 2014
update photo-browser.js, add ofText config option
@nolimits4web nolimits4web merged commit 326d148 into framework7io:master Jul 30, 2014
@nolimits4web
Copy link
Member

Ok, merged, thanks

@lock
Copy link

lock bot commented Jun 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Jun 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants