Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4304 - popup.params sometimes undefined #4305

Closed
wants to merge 2 commits into from

Conversation

scp
Copy link

@scp scp commented Jan 19, 2025

In core/vanilla - seeing this error from iOS users - managed to track it down to specifically when users use the iOS app switcher/or the app loses focus whilst the popup is open - when user returns to the app the error is triggered:

undefined is not an object (evaluating 'i.params.swipeToClose')

framework7-ss

scp added 2 commits January 19, 2025 16:43
In core/vanilla - seeing this error from iOS users - managed to track it down to specifically when users use the iOS app switcher/or the app loses focus whilst the popup is open - when user returns to the app the error is triggered:

undefined is not an object (evaluating 'i.params.swipeToClose')
@nolimits4web
Copy link
Member

The question is why in your app they end up like this? In your console log it specifically says that popup is destroyed. I guess you shouldn't destroy it then if you still need it

@scp
Copy link
Author

scp commented Jan 20, 2025

Thanks for the pointer @nolimits4web - the app automatically navigates to another page on receiving app focus.

When there is a popup previously on the screen, the navigation must cause the popup to be destroyed, but it also generates this error.

I've changed the navigation logic for when there is a modal on screen to avoid the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants