Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template7 page rerendering #751

Closed
wants to merge 2 commits into from

Conversation

antono
Copy link

@antono antono commented Dec 10, 2015

Its possible to update template7 pages with new data.

@ZanderBrown
Copy link
Contributor

This looks to be of some interest. @valnub ?

@valnub
Copy link
Collaborator

valnub commented Jan 22, 2017

@ZanderBrown Yeah, but Vladi knows F7 core rendering functionality better than me, so he'll have to decide if this gets merged.

@ZanderBrown
Copy link
Contributor

@valnub sure, i was just going through the older issues/pr's and saw that this seemed to have gone unnoticed.

So @nolimits4web what do you think?

@J05HI
Copy link

J05HI commented Jan 29, 2017

@nolimits4web
Please add this. It's amazing!

@antono
Copy link
Author

antono commented Feb 8, 2017

👍

@J05HI
Copy link

J05HI commented Mar 1, 2017

@nolimits4web
What's up? Please merge it :)

@ZanderBrown
Copy link
Contributor

@J05HI you will notice that there are merge conflicts, hence the red label

@J05HI
Copy link

J05HI commented Mar 2, 2017

Yeah then @antono should fix them

Copy link

@J05HI J05HI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, tested and working.

@J05HI
Copy link

J05HI commented Mar 3, 2017

@ZanderBrown
I'll fork it and fix the merge conflicts.

@ZanderBrown
Copy link
Contributor

@J05HI PR still has merge conflicts that @antono hasn't resolved

@J05HI J05HI mentioned this pull request Mar 3, 2017
@J05HI
Copy link

J05HI commented Mar 3, 2017

@nolimits4web @ZanderBrown @valnub

You can close this now because of #1391.

@ZanderBrown
Copy link
Contributor

Okay closing in favour of #1391

@ZanderBrown ZanderBrown closed this Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants