Enable auth process in new tab instead of popup by reseting popup wid…

…th and height
frankwrk · Oct 1, 2017 · 5b9d14c · 5b9d14c
1 parent e351407
commit 5b9d14c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/oauth/oauth1.js b/src/oauth/oauth1.js
@@ -12,7 +12,7 @@ const defaultProviderConfig = {
   requiredUrlParams: null,
   defaultUrlParams: null,
   oauthType: '1.0',
-  popupOptions: { width: null, height: null }
+  popupOptions: {}
 }
 
 export default class OAuth {

diff --git a/src/oauth/oauth2.js b/src/oauth/oauth2.js
@@ -24,7 +24,7 @@ const defaultProviderConfig = {
     redirectUri: 'redirectUri'
   },
   oauthType: '2.0',
-  popupOptions: { width: null, height: null }
+  popupOptions: {}
 }
 
 export default class OAuth2 {

diff --git a/src/oauth/popup.js b/src/oauth/popup.js
@@ -1,5 +1,5 @@
 import Promise from '../promise.js'
-import { objectExtend, parseQueryString, getFullUrlPath } from '../utils.js'
+import { objectExtend, parseQueryString, getFullUrlPath, isUndefined } from '../utils.js'
 
 /**
  * OAuth2 popup management class
@@ -79,7 +79,9 @@ export default class OAuthPopup {
   _stringifyOptions() {
     let options = []
     for (var optionKey in this.popupOptions) {
-      options.push(`${optionKey}=${this.popupOptions[optionKey]}`)
+      if (!isUndefined(this.popupOptions[optionKey])) {
+        options.push(`${optionKey}=${this.popupOptions[optionKey]}`)
+      }
     }
     return options.join(',')
   }