Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use best practice #331

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

blaggacao
Copy link
Collaborator

No description provided.

@blaggacao blaggacao requested a review from ankush as a code owner October 2, 2024 02:02
@blaggacao blaggacao changed the title ci/use best practice ci: use best practice Oct 2, 2024
@blaggacao
Copy link
Collaborator Author

blaggacao commented Oct 2, 2024

@rmehta Could you please adapt the branch protection rules to check for the updated ci actions? Server is old and test have been broken anyway for months. I fixed them here.

@rmehta
Copy link
Member

rmehta commented Oct 5, 2024 via email

@blaggacao
Copy link
Collaborator Author

@rmehta Thanks, unfortunately, that doesn't seem to be "enough" for this configuration. I don't want to escalate my privileges too much, so I'd be very happy if someone from staff could have a quick look:

  • Context: ecommerce_integration
  • Problem: Old branch protection on "Sever" event; now "Python Unit Tests (1)"
  • Ask: Update Branch Protection Rules to the new event
  • Probably direct link (no access, construed): https://github.com/divnix/std/settings/branches then click on the rule and update the event

@blaggacao blaggacao merged commit ba5b543 into frappe:develop Oct 8, 2024
7 checks passed
@rmehta
Copy link
Member

rmehta commented Oct 8, 2024

updated. check? also updated you to "admin"

@blaggacao blaggacao deleted the ci/use-best-practice branch October 8, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants